Open
Conversation
jmrohwer
force-pushed
the
spinsolve_importer
branch
from
97bb4db to
980e093
Compare
Collaborator
Author
|
@torogi94 any progress on the review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to import raw data from Magritek Spinsolve benchtop NMR spectrometers.
Test data and appropriate unit tests are included.
In addition the unit test suite is fixed and cleaned up to remove duplicate test names.
Once reviewed and accepted, this should be merged as a single squashed commit into main.